Remove Artifactory publishing logic from gradle build #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer need the artifactory publishing logic that we used to use for publishing in the gradle build as new releases are no longer being published there. This removes the now dead code from the build, which means we no longer need to include the artficatory plugin in our build-time dependencies, which is nice. There are a few other build files that appear to be dead code that we can remove, but this is more targetted. This resolves FoundationDB#3249.
ScottDugas
requested changes
Mar 18, 2025
| @@ -37,7 +37,6 @@ plugins { | |||
| alias(libs.plugins.versions) | |||
| alias(libs.plugins.spotbugs) | |||
| alias(libs.plugins.nexus) | |||
| alias(libs.plugins.artifactory) | |||
There was a problem hiding this comment.
Can this be removed from libs.versions.toml now?
There was a problem hiding this comment.
Oh whoops. Definitely meant to remove it the first time. Yeah, it's unreferenced now. Removed
| @@ -74,17 +73,6 @@ if (ext.publishLibrary) { | |||
| } | |||
| } | |||
| } | |||
| artifactoryPublish { | |||
There was a problem hiding this comment.
This does mean that build.py will break, but we're not using that anywhere, and plan to remove it very shortly, so that seems fine.
There was a problem hiding this comment.
Yeah. I've filed #3257 to do just that. Given that build.py is also unused by our build process, I think it's okay if it's broken. Or we remove it first.
ScottDugas
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need the artifactory publishing logic that we used to use for publishing in the gradle build as new releases are no longer being published there. This removes the now dead code from the build, which means we no longer need to include the artficatory plugin in our build-time dependencies, which is nice.
There are a few other build files that appear to be dead code that we can remove, but this is more targeted. I've validated that I can still publish to maven local with this change, and all of the logic seems to be pretty specific to actually running an artifactory build, so this shouldn't disrupt our other build procedures, but I guess one never knows.
This resolves #3249.